Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "chore(docs): workaround netlify pnpm build issue (#11477)" #11759

Merged
merged 14 commits into from
Jan 20, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 20, 2023

Description

This PR does:

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red marked this pull request as draft January 20, 2023 04:47
@sapphi-red
Copy link
Member Author

OK. I found what was causing the build failure. There was a duplicated package name.
@netlify/build-info failed to obtain the info and the build failed with jq getting null.
https://github.com/netlify/build-image/blob/632a0e9c1543e2e7b55a9d51497b468514a8e6ca/tests/get-build-info.mjs#L14
https://app.netlify.com/sites/vite-docs-main/deploys/63ca1b7c4091d30009e298d3#L34

@sapphi-red
Copy link
Member Author

sapphi-red commented Jan 20, 2023

I guess this is failing because the cache is broken. jest shouldn't be in node_modules but it existed.

@sapphi-red
Copy link
Member Author

Yep, it worked

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jan 20, 2023
@sapphi-red sapphi-red marked this pull request as ready for review January 20, 2023 07:35
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is great sleuthing Sapphi. Thanks for fixing this!

@patak-dev patak-dev merged commit ac0733f into vitejs:main Jan 20, 2023
@sapphi-red sapphi-red deleted the chore/revert-11477 branch January 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants