fix(types): avoid resolve.exports types for bundling #12346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
the
p4-important
|
|
patak-dev
approved these changes
Mar 9, 2023
|
ecosystem-ci run after this PR here https://github.com/vitejs/vite-ecosystem-ci/actions/runs/4373070250 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid
resolve.exportstypes when bundling types, this causestscerrors downstream as Vite's types is importing fromresolve.exports(which is a dev dep).This was introduced from #7770
Ideally we would vendor
resolve.exportstypes like thesrc/typesconvention, but I found the types written byresolve.exportswhen vendored caused more errors. So I went with this simpler fix.Additional context
What is the purpose of this pull request?