Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(create-vite): use quotes for attributes consistently #12383

Merged

Conversation

XanderXAJ
Copy link
Contributor

Description

As part of my changes in #12374, I unintentionally removed the quotes for the Vite logos from the vanilla templates, perhaps because the rest of the templates didn't need them.

While HTML5 allows no quotes for attribute values if the value doesn't contain a space, keeping a consistent style is important for cognitive load when reading and maintaining. Hence, I've marked this as a style change.

While not a functional change in these templates, it could be if someone later changed the import path to contain a space (perhaps after generating a project using the template).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

As part of my changes in vitejs#12374, I unintentionally removed the quotes
for the Vite logos from the vanilla templates, perhaps because the rest
of the templates didn't need them.

While HTML5 allows no quotes for attribute values if the value doesn't contain
a space, keeping a consistent style is important for cognitive load when
reading and maintaining. Hence, I've marked this as a style change.

While not a functional change in these templates, it could be if someone
later changed the import path to contain a space (perhaps after
generating a project using the template).
@stackblitz
Copy link

stackblitz bot commented Mar 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't notice this. Thanks for following up on it.

@bluwy bluwy merged commit 46c5f46 into vitejs:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants