feat(importMetaGlob): support sub imports pattern

[sun0day]

Description

fix #12465

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[sun0day]

I think we can consider supporting read modules via sub imports path like #12221. There will be 3 glob patterns: normal pattern, alias pattern and sub imports pattern. Each pattern's module entry key has its own style.

[bluwy]

LGTM. In the future maybe we can improve the custom glob resolver to handle aliases only, but I think this is good enough for now.

EDIT: That might be what you mean in #12467 (comment), but I have no context of that PR and issue yet 😬

[patak-dev]

/ecosystem-ci run

[patak-dev]

/ecosystem-ci run astro

[sun0day]

I am not familiar with astro. Can you help check out why this fails @bluwy Thanks.

[bluwy]

I think it's flaky tests happening, but since this is sort-of a feature too, we've pushed it to the next minor so we can test more extensively with Astro.

[patak-dev]

@bluwy feel free to merge it when you feel it is better, let's start the 4.3 beta period 🙌

[bluwy]

/ecosystem-ci run astro

[bluwy]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	❌ failure
histoire	❌ failure
iles	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	❌ failure
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	❌ failure
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success

[bluwy]

The current failures also fail in main, except Astro again 😭 I'm quite inclined to merge this still because Astro's CI error doesn't makes sense that it'd be affected by this PR.

[sun0day]

The current failures also fail in main, except Astro again 😭 I'm quite inclined to merge this still because Astro's CI error doesn't makes sense that it'd be affected by this PR.

Maybe this pr triggers a bug in astro. It looks like the errors are the same between each ecosystem-run

[patak-dev]

@bluwy I also think we should merge this one, we have time to fix Astro if it is affecting it (but as you say, I doubt is related)

About the custom option, maybe we should use a namespace for it to avoid collisions? Something like 'vite:import-glob:imports' or 'vite:import-glob-imports' ?

[bluwy]

Yeah if this gets merged, I'll monitor Astro again for errors. A namespace sounds nice too, maybe we should follow the Vite plugin name we use vite:import-glob, since there's also custom['node-resolve'].

[patak-dev]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success
histoire	✅ success
iles	✅ success
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	✅ success
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	❌ failure
windicss	✅ success

[patak-dev]

Updated the custom naming to:

    (await resolveId(glob, importer, {
      custom: { 'vite:import-glob': { isSubImportsPattern } },
    })) || glob,

Let's move this one to the 4.4 milestone, better to avoid merging just before the release.