fix(worker): disable manifest plugins in worker build #12661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building worker files with Vite plugins, disable the manifest plugins as workers don't need a manifest file. Otherwise the manifest gets emitted into the main Vite build bundle here:
vite/packages/vite/src/node/plugins/worker.ts
Lines 389 to 399 in 273c032
So when the actual manifest plugin on the main build runs, you would get this warning from Rollup:
Additional context
In most case, this is harmless, but there seems to be an fs race condition where the worker manifest gets written down in a SvelteKit build 🤔
It isn't easy to write a test for this too, the logs come from Rollup, and we don't have a setup to track Rollup logs.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).