fix(build): declare moduleSideEffects for vite:modulepreload-polyfill

[linl33]

Description

Add moduleSideEffects: true property to vite:modulepreload-polyfill. The polyfill is effectful so it needs be declared as such otherwise it could be removed by Rollup.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

Seems like this is only caused because you've configured rollup with rollupOptions.treeshake.moduleSideEffects: false, but I don't think this addition hurts so sounds fine to me.

[bluwy]

it doesn't look like this file is used. Could we remove it?

[linl33]

Just removed it, I forgot to delete it.

[linl33]

rollupOptions.treeshake.moduleSideEffects defaults to true but when it's set to false or an array (that doesn't include vite:modulepreload-polyfill) the polyfill gets removed by tree-shaking. (When it's set to a callback, modules whose name starts with '\0' are never considered side-effect free.)