Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): error caused by single quote in filename when base sets to relative path #13118

Closed
wants to merge 1 commit into from

Conversation

zonemeen
Copy link

@zonemeen zonemeen commented May 8, 2023

Description

fix #13116

Since characters of the form ""+new URL('javascript'-8dac5379.svg', import.meta.url).href+"" contain more than two single quotes, it cannot pass the transform.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented May 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Would you add some tests for these cases?

Also, I think we'll have the same issue after your changes but with ". Maybe we should start using JSON.stringify here. We copied this code from rollup, so if we change this, it would also be good to change it there. cc @sapphi-red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single quote in image name and setting base causes an error
3 participants