fix(build): silence warn dynamic import module when inlineDynamicImports true #13970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Disservin
force-pushed
the
13967-silence-warning
branch
from
01e1879 to
9dac35b
Compare
patak-dev
reviewed
Jul 27, 2023
patak-dev
previously approved these changes
Jul 27, 2023
patak-dev
added
p3-minor-bug
btea
reviewed
Jul 28, 2023
|
@Disservin would you resolve the conflicts when you get some time? We merged: |
patak-dev
approved these changes
Jul 28, 2023
bluwy
approved these changes
Aug 1, 2023
bluwy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #13967. Skip the module check if
inlineDynamicImportsis enabled.Additional context
I'm a bit unsure about the multiple arrays which rollup supports. I think in vite we support only 1 anyway and at some other place in the code it always took the first one too. Also I'm not sure if the test was added in the correct place/way.
What is the purpose of this pull request?