Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: detect Bun package manager in create-vite #14017

Merged
merged 7 commits into from
Sep 3, 2023
Merged

docs: detect Bun package manager in create-vite #14017

merged 7 commits into from
Sep 3, 2023

Conversation

colinhacks
Copy link
Contributor

@colinhacks colinhacks commented Aug 3, 2023 •
edited
Loading

Bun can now run Vite successfully, so this PR adds instructions for using Vite with Bun.

  • Adds bun package manager to docs

Description

What is the purpose of this pull request?

  • Documentation update
  • Other (create-vite updates)

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@stackblitz
Copy link

stackblitz bot commented Aug 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@colinhacks colinhacks changed the title docs: add Bun to docs and create-vite docs: detect Bun package manager in create-vite Aug 10, 2023
bluwy
bluwy previously approved these changes Aug 22, 2023
View reviewed changes
sapphi-red
sapphi-red reviewed Aug 30, 2023
View reviewed changes
docs/guide/index.md Show resolved Hide resolved
docs/guide/troubleshooting.md Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Aug 30, 2023
@patak-dev patak-dev merged commit 4d3cdd1 into vitejs:main Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colinhacks @patak-dev @ArnaudBarre @bluwy @sapphi-red