Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bun prefix to ssr resolver (fix #14351) #14390

Closed
wants to merge 1 commit into from
Closed

fix: add bun prefix to ssr resolver (fix #14351) #14390

wants to merge 1 commit into from

Conversation

andrioid
Copy link

Description

Allow Vite to resolve internal bun: packages. Resolves #14351

Additional context

I'd love to improve this, if needed. It's a pretty straight forward change. Maybe maintainers want to make a more robust way of excluding packages from the node resolver plugin?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@andrioid andrioid changed the title Fix: #14351 - Add bun prefix to ssr resolver fix: Add bun prefix to ssr resolver (fix #14351) Sep 16, 2023
@andrioid andrioid changed the title fix: Add bun prefix to ssr resolver (fix #14351) fix: add bun prefix to ssr resolver (fix #14351) Sep 16, 2023
@andrioid
Copy link
Author

A better solution has presented itself, closing
#14379

@andrioid andrioid closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to resolve bun:* packages
1 participant