refactor(css): make getEmptyChunkReplacer for unit test
#14528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bluwy
reviewed
Oct 3, 2023
…t tested Also refactor replacer code into `getEmptyChunkReplacer` function. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/refactor-css-removal-as-function-for-testing
branch
from
ed7bf3b to
e791692
Compare
bluwy
reviewed
Oct 4, 2023
bluwy
changed the title
removePureCssChunks a function so it can be unit testedgetEmptyChunkReplacer for unit test
bluwy
approved these changes
Oct 10, 2023
|
@bluwy Thank you for taking care! I was a bit short on time. |
patak-dev
approved these changes
Oct 10, 2023
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the css plugin code a bit to allow unit testing the remove css chunks part.
Done as a separate PR to get an initial snapshot, as suggested here: #14517 (review)
Additional context
Already added the unit tests which show the invalid code.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).