Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): relative paths without leading dot wasn't rewritten #14591

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 12, 2023

Description

When the base is without trailing slash, relative path without leading dot wasn't working.

<script src="asset/main.js" type="module"></script>

The first commit simply changes the base (this will make the test fail even with the paths in the test is updated).
The second commit is the actual fix.

This bug was found in #5657.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Oct 12, 2023
@sapphi-red sapphi-red force-pushed the fix/html-relative-path-without-dot branch 2 times, most recently from b713f55 to 156f605 Compare October 12, 2023 05:31
@sapphi-red sapphi-red force-pushed the fix/html-relative-path-without-dot branch from 156f605 to bd0f770 Compare October 12, 2023 05:52
@patak-dev patak-dev merged commit 0a38e3b into vitejs:main Oct 12, 2023
10 checks passed
@sapphi-red sapphi-red deleted the fix/html-relative-path-without-dot branch October 12, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants