Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: avoid importing large deps #14828

Merged
merged 2 commits into from
Nov 1, 2023
Merged

docs: avoid importing large deps #14828

merged 2 commits into from
Nov 1, 2023

Conversation

sapphi-red
Copy link
Member

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Oct 31, 2023
bluwy
bluwy reviewed Nov 1, 2023
View reviewed changes
docs/guide/performance.md Outdated Show resolved Hide resolved
@sapphi-red @bluwy
docs: update, thanks blu
58cfa13 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy bluwy merged commit 90e6108 into vitejs:main Nov 1, 2023
@sapphi-red sapphi-red deleted the docs/perf-dont-import-heavy-deps branch November 14, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @ArnaudBarre @bluwy