fix(worker): prevent inject esm in classic workers #14918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #11266
supersedes #12995
importAnalysis
could run on classic worker code, which I think is the only non-ESM code we allow to be processed (?). This PR checks for classic workers and avoid adding top-level imports.This should also fix the confusing errors from #5396 (does not fix the issue)
Additional context
The fix isn't really clean. I can't think of a way to inline
__vite__injectQuery
without a significant refactoring.The test is also subpar but it somewhat works 😬
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).