test: avoid vitest checking publicDir

[patak-dev]

Description

I saw that Vitest when run in the monorepo was checking for vite-path/public while working on #15195. This PR disables the publicDir feature for vitest as we aren't using it.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

I think it makes sense to disable in the vitest configs, but do we also need to disable in the manual createServer calls? I think it might be more consistent to leave it unset.

[sapphi-red]

I think it makes sense to disable in the vitest configs, but do we also need to disable in the manual createServer calls? I think it might be more consistent to leave it unset.

I thought about that too. I'm slightly leaning toward not disabling it in the manual createServer calls, but either is fine for me.

[patak-dev]

Because of the way we use vitest to run unit tests in the monorepo, these deep createServer calls end up with the publicDir enabled at (monorepo-root)/public. I agree we shouldn't disable the public repo in the playgrounds (were it is enabled at (playground-root)/public but these createServer in the unit tests are testing something unrelated to it and it is quite confusing to have it enabled at the monorepo root to me. I can re-enable them though if you prefer that, let me know.

[bluwy]

Perhaps we can set the root instead so it's correctly testing against a directory. I would prefer if we don't adjust those publicDir options though unless there's a perf improvement.

[patak-dev]

There is a perf improvement now, but it will be negated if we merge:

• perf: in-memory public files check #15195

I'll remove the changes there for now then, and only leave the ones in Vitest. One problem we may have though is that if these servers start to use the public dir at one point, it may fail because we disable the feature in the vitest config for unit tests (so I still think it is better to disable them, but not a big deal)