Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use dedicated regex methods #15228

Merged

Conversation

sapphi-red
Copy link
Member

Description

  • use hasIndices flag (d)
  • foo.slice(ops).match(regex) -> regex.lastIndex = pos; regex.exec(foo)
  • !!foo.match(regex) -> regex.test(foo)
  • !!foo.match(string) -> foo.includes(string)
  • foo.match(regex)?.index -> foo.search(regex)
  • regex.test() -> .startsWith()/.endsWith()/.includes()
  • expect(foo.match(string)).toBeNull() -> expect(foo).toContain(string)
  • (fix) add .lastIndex = 0 before /something/g.test(something)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 3, 2023
Copy link

stackblitz bot commented Dec 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@patak-dev patak-dev merged commit 0348137 into vitejs:main Dec 3, 2023
10 checks passed
@sapphi-red sapphi-red deleted the refactor/use-dedicated-regex-methods branch December 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants