refactor: use dedicated regex methods #15228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hasIndices
flag (d
)foo.slice(ops).match(regex)
->regex.lastIndex = pos; regex.exec(foo)
!!foo.match(regex)
->regex.test(foo)
!!foo.match(string)
->foo.includes(string)
foo.match(regex)?.index
->foo.search(regex)
regex.test()
->.startsWith()
/.endsWith()
/.includes()
expect(foo.match(string)).toBeNull()
->expect(foo).toContain(string)
.lastIndex = 0
before/something/g.test(something)
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).