Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use eslint-plugin-i #15569

Merged
merged 2 commits into from
Jan 11, 2024
Merged

chore: use eslint-plugin-i #15569

merged 2 commits into from
Jan 11, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 11, 2024

Description

Use eslint-plugin-i instead of eslint-plugin-import to remove a bunch of useless polyfill packages.

https://github.com/un-es/eslint-plugin-i is an active fork of eslint-plugin-import.

Additional context

I noticed the license file is updated on build after some recent deps update, which adds new polyfill packages licenses. Trying to remove the useless polyfill packages step-by-step.

NOTE: @eslint-types/import package now doesn't work for eslint-plugin-i, but I left it as is until it has a new package in the future we could use. cc @Shinigami92


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Jan 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Shinigami92
Copy link
Member

@eslint-types/import can safely removed. It only adds type safety and documentation for rules, extends and so on in eslint config

Either eslint-plugin-i need to ship support for eslint-define-config from their side, or they should provide a reason why they can't ship support from their side and so I need to add support from @eslint-types/i. The later one is less preferred.

@bluwy
Copy link
Member Author

bluwy commented Jan 11, 2024

eslint-plugin-i is a plain fork of eslint-plugin-import, so I guess they share the same reason. But I'm not really familiar with this territory of eslint in general.

@patak-dev patak-dev merged commit a1f8082 into main Jan 11, 2024
10 checks passed
@patak-dev patak-dev deleted the use-eslint-plugin-i branch January 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants