fix: maintain compatibility with rollup when loading commonjs module #15600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #15542
Additional context
From the following repository examples:
https://github.com/XiSenao/exceptional-performance-of-loading-commonjs-modules/blob/main/src/main.js
it can be found that using
namespace imports
to loadCommonJS
modules results in inconsistent development and build behaviors. In most cases,dynamic import
behaves as expected. That is to say, it seems effective to rewrite in the following way.However, when exploring how the
@rollup/plugin-commonjs
plugin interacts withrollup
, it seems thatrollup
will merge the transpiledESM
product throughThe logic of the
rollup
processing and the rewrittendynamic import
are somewhat similar, but it can be found that there are still boundary scenarios that will cause inconsistencies between development and build behaviors fordynamic imports
(e.g. only exportArray
).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).