Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): set "strict: true" in tsconfig.node.json #15820

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat(create-vite): set "strict: true" in tsconfig.node.json #15820

merged 1 commit into from
Feb 8, 2024

Commits on Feb 6, 2024

  1. feat(create-vite): Set "strict: true" in tsconfig.node.json 

    When using @typescript-eslint/strict-type-checked rule set on a
fresh Vite project and vite.config.ts is included in the files
that eslint runs on, it results in the following error:

  0:1  error  This rule requires the `strictNullChecks` compiler option to be turned on to function correctly  @typescript-eslint/prefer-nullish-coalescing
  0:1  error  This rule requires the `strictNullChecks` compiler option to be turned on to function correctly  @typescript-eslint/no-unnecessary-condition

Given that we have "strict" enabled in the main tsconfig.json
it makes sense to have it enabled here too.
    @philbates35
    philbates35 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a35ced7 View commit details
    Browse the repository at this point in the history