Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip not only .js but also .mjs manifest entries #15841

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

brillout
Copy link
Contributor

@brillout brillout commented Feb 8, 2024

Description

The current manifest generation logic is faulty if manifest[src].file ends with .mjs instead of .js. This PR fixes it.

Additional context

This bug is breaking a production app.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@brillout brillout force-pushed the brillout/fix-manifest branch from 5106998 to a79c894 Compare February 8, 2024 11:48
@brillout
Copy link
Contributor Author

brillout commented Feb 8, 2024

I think the CI is green; the one failure seems to be a falky test.

@patak-dev patak-dev enabled auto-merge (squash) February 8, 2024 15:10
@patak-dev patak-dev merged commit 3d860e7 into vitejs:main Feb 8, 2024
10 checks passed
@brillout brillout deleted the brillout/fix-manifest branch September 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants