-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimizeDeps.entries with literal-only pattern(s) #15853
fix: optimizeDeps.entries with literal-only pattern(s) #15853
Conversation
Run & review this pull request in StackBlitz Codeflow. |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good to me. An alternative would be to let the user specify a pattern that has node_modules
, in which case node_modules won't be ignored. Maybe we could also do that in a future PR if needed. But your solution is better for now.
/ecosystem-ci run |
📝 Ran ecosystem CI on
|
The AnalogJS fail is unrelated to this PR. |
So I guess this is ready to merge? @patak-dev 🙂 |
We wait for two approvals for this kind of PR. |
Description
Skip running
fast-glob
ifoptimizeDeps.entries
is specified without any special characters like$^*+?[]()
.So user can specify a entry in literal value to skip the
fast-glob
ignore policy.Additional context
#15613 (reply in thread)
#15746
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).