Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): hide "The emitted file overwrites" warning if the content is same #16094

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 5, 2024

Description

The build error in #10057 was fixed by #15469. This PR suppresses the "The emitted file overwrites" warning by skipping this.emitFile if the filename and the content is same.

If the filename is same but the content is different and the warning happens, then I think the user should configure worker.rollupOptions.output.chunkFileNames.

fixes #10057

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: web workers labels Mar 5, 2024
Copy link

stackblitz bot commented Mar 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@patak-dev patak-dev merged commit 60dfa9e into vitejs:main Mar 5, 2024
11 checks passed
@sapphi-red sapphi-red deleted the fix/worker-hide-emitted-file-overwrites-warning branch March 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: web workers p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when Web Worker dynamically imports module also dynamically imported by the main thread
2 participants