Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: plugin container #17288

Merged
merged 6 commits into from
May 29, 2024
Merged

refactor: plugin container #17288

merged 6 commits into from
May 29, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented May 23, 2024

Redo #16740 against main.

Copy link

stackblitz bot commented May 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu antfu marked this pull request as draft May 23, 2024 14:00
@antfu antfu marked this pull request as ready for review May 23, 2024 14:51
@antfu
Copy link
Member Author

antfu commented May 23, 2024

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

patak-dev
patak-dev previously approved these changes May 23, 2024
@patak-dev patak-dev added this to the 5.3 milestone May 23, 2024
@patak-dev
Copy link
Member

Awesome! If we want to merge this one before v6, let's do it in 5.3

@patak-dev patak-dev added the performance Performance related enhancement label May 23, 2024
bluwy
bluwy previously approved these changes May 23, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit but otherwise looks great! Glad to see ecosystem-ci passing too.

packages/vite/src/node/server/pluginContainer.ts Outdated Show resolved Hide resolved
@antfu antfu dismissed stale reviews from bluwy and patak-dev via ca9d5e9 May 23, 2024 21:39
@bluwy bluwy merged commit 4aa4a80 into main May 29, 2024
11 checks passed
@bluwy bluwy deleted the refactor/plugin-container-main branch May 29, 2024 14:19
antfu added a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants