Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add region comment #17370

Merged
merged 3 commits into from
Jun 3, 2024
Merged

chore: add region comment #17370

merged 3 commits into from
Jun 3, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Jun 1, 2024

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to add a trailing #endregion along too. That way the editor can collapse the region together

@patak-dev patak-dev enabled auto-merge (squash) June 3, 2024 14:14
@patak-dev patak-dev merged commit a8c7083 into vitejs:main Jun 3, 2024
11 checks passed
@btea btea deleted the chore/add-region-comment branch June 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btea @patak-dev @bluwy