-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Angular example #18330
feat: add Angular example #18330
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@@ -40,6 +40,7 @@ The supported template presets are: | |||
| [svelte](https://vite.new/svelte) | [svelte-ts](https://vite.new/svelte-ts) | | |||
| [solid](https://vite.new/solid) | [solid-ts](https://vite.new/solid-ts) | | |||
| [qwik](https://vite.new/qwik) | [qwik-ts](https://vite.new/qwik-ts) | | |||
| | [angular-ts](https://vite.new/angular-ts) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is a placeholder 👍
Thanks for the PR @gioboa! We discussed with @brandonroberts and others in the Vite team about it, and we think that having a starter for Angular may be a bit confusing. Brandon would recommend users to start from an Analog starter, and the Angular team would prefer folks to use their own Angular starter. It is still a good idea to have Angular in create-vite. What do you think if we remove the template, and instead we add an Angular option to create-vite that will have two custom commands (one to create an Angular app, another one to create an Analog app). Like we do for Vue/Nuxt, but in this case there will only be external create options and no template. See #18330 What do you think? |
Thanks for the exhaustive explanation. This sounds great to me too. That's a good option |
Let us know if you'd like to try to PR that feature @gioboa. Or we'll take it over. |
I'll do the PR for that. 😉 |
@patak-dev this is my PR, can you point me to the right one please? |
Oh, sorry about the wrong link. This is how we do the jump to create-nuxt in the Vue option vite/packages/create-vite/src/index.ts Line 109 in bae6a37
|
I remember the integration with React, although the official default was CRA I was very happy to use Vite for its simplicity and speed. Angular has its official CLI, but thanks to
@analogjs/vite-plugin-angular
you can exploit the potential of Vite with Angular.Hope that helps.