chore: use rolldown-plugin-dts for dts bundling #19990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
force-pushed
the
chore/switch-to-rolldown-dts
branch
from
1570128 to
accd137
Compare
sapphi-red
force-pushed
the
chore/switch-to-rolldown-dts
branch
from
accd137 to
49e0349
Compare
patak-dev
previously approved these changes
May 20, 2025
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
It would be nice to wait until rolldown/rolldown#4324 is resolved, but it is probably ok to move forward to have the whole build pipeline driven by rolldown.
Member
Author
|
I've pushed a commit that removes unnecessary entries in |
Member
Author
The type name in the error is not ideal, but I think it's ok for now. |
patak-dev
approved these changes
May 22, 2025
Dunqing
reviewed
May 23, 2025
Member
Author
|
Ah, I'll rename them |
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces rollup + rollup-plugin-dts with rolldown + rolldown-plugin-dts.