Skip to content

refactor!: bump required node version to 20.19+, 22.12+ and remove cjs build #20032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 21, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented May 13, 2025

Description

Built on top of #19972

Bumps required node version to 20.19+, 22.12+ so that we can remove cjs build.

I haven't tested yet.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) breaking change labels May 13, 2025
@sapphi-red sapphi-red force-pushed the refactor/remove-cjs-build branch from f6411d5 to 3f8efbc Compare May 16, 2025 03:43
@sapphi-red sapphi-red mentioned this pull request May 20, 2025
@sapphi-red sapphi-red force-pushed the refactor/remove-cjs-build branch from 3f8efbc to a3e7a73 Compare May 20, 2025 12:36
@sapphi-red sapphi-red marked this pull request as ready for review May 21, 2025 04:47
@sapphi-red sapphi-red added this to the 7.0 milestone May 21, 2025
bluwy
bluwy previously approved these changes May 21, 2025
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such a great milestone! awesome work everywhere sapphi

@patak-dev patak-dev merged commit 2b80243 into vitejs:main May 21, 2025
15 checks passed
@sapphi-red sapphi-red deleted the refactor/remove-cjs-build branch May 22, 2025 01:23
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants