fix(hmr): use monotonicDateNow for timestamp #20158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
feat: hmr
p3-minor-bug
hi-ogawa
approved these changes
Jun 5, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Looks good 👍
Sometime ago I've attempted fixing this by using higher precision but it was somehow tricky to deal with fractional value as timestamp and it was breaking. I worried that module graph property like ModuleNode.lastInvalidationTimestamp, lastHMRTimestamp not being an actual Date.now value might break some users assumption, but I think fluctuation of a few milliseconds shouldn't cause issues in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered a flaky failure related to these tests and once thought the cause is #19804. But it turned out, it wasn't 😅.
Anyway, it would be good to fix this issue, so I made this PR.
This PR changes
Date.now()tomonotinicDateNow()so that the timestamp is always different for each update.fixes #19804