fix(module-runner): resolve resolvedSources correctly
#20959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looking for a way to support this in all Vite versions from my side since I doubt it makes a lot of sense to backport this to every minor. EDIT: Probably, will keep this until we bump the version: vitest-dev/vitest#8736 |
sheremet-va
changed the title
resolvedSources correctly
sapphi-red
reviewed
Oct 19, 2025
packages/vite/src/node/ssr/runtime/__tests__/server-source-maps.spec.ts
Outdated
Show resolved
Hide resolved
sapphi-red
added
the
p2-edge-case
bluwy
approved these changes
Oct 20, 2025
sapphi-red
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not sure when this happened, but the order of arguments in
posixResolveis not correct, it always returns thefromvalue because it's always absolute.This was hard to detect because it's almost always irrelevant. You need a file that was already generated from another file.