fix: handle query parameters for /@vite/* modules
#20998
Merged
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import cleanUrl from shared/utils in clientInjections.ts - Use cleanUrl(id) before comparing with normalizedClientEntry and normalizedEnvEntry - Add test case that imports /@vite/env?foo to verify the fix - Ensures __DEFINES__ is properly replaced even when query parameters are present Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with cleanUrl function in error handling
fix: handle query parameters in client and env entry URLs
Oct 24, 2025
Copilot stopped work on behalf of
sapphi-red due to an error
October 24, 2025 08:36
Member
|
@copilot add the import by a plugin. only apply that plugin when commamd is dev. |
Move the test import from inline code to a vite plugin that only applies during dev mode. This ensures the test doesn't run during build, making it more robust and following best practices. Addresses feedback from @sapphi-red Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Contributor
Author
Done. The test import is now added by a plugin with |
Copilot finished work on behalf of
sapphi-red
October 24, 2025 09:40
sapphi-red
approved these changes
Oct 26, 2025
sapphi-red
changed the title
/@vite/* modules
sapphi-red
added
p2-edge-case
bluwy
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/@vite/env?footo verify the fixIssue Summary
The issue (#20997) is in
/packages/vite/src/node/plugins/clientInjections.ts. When query parameters are appended to the env entry URL (e.g.,/@vite/env?token=xxx), the strict equality check fails, causing__DEFINES__to not be replaced, resulting in a ReferenceError.Solution
cleanUrlfrom../../shared/utilscleanUrl(id)to strip query parameters before comparing withnormalizedClientEntryandnormalizedEnvEntryplayground/define/vite.config.jsthat adds the test import during transformationapply: 'serve'to ensure it only runs in development modeTesting
The test imports
/@vite/env?foovia a plugin that only applies during dev mode, ensuring the fix works correctly without affecting build behavior.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.