test: Prevent regressions in static file serving of files outside the root #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
changed the title
ElMassimo
commented
Mar 3, 2021
| const execRoot = process.cwd() | ||
| const playgroundDir = execRoot.includes('playground') | ||
| ? path.resolve(__dirname, '..') // Allow running vite locally inside the folder. | ||
| : path.resolve(execRoot, 'packages/playground') |
There was a problem hiding this comment.
This could be simplified if we assume Vite is always run by jest, but added it in case folks run vite manually from the assets folder when debugging, so that it always resolves as expected.
ElMassimo
force-pushed
the
test-static-file-serving
branch
from
5955dcb to
674d4a2
Compare
ElMassimo
force-pushed
the
test-static-file-serving
branch
from
674d4a2 to
3978e06
Compare
antfu
added
p3-downstream-blocker
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
…ide the root (vitejs#2358) (vitejs#3015) This reverts commit ee7eb82.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds a test to prevent regressions in static file serving as in #2201, which has a high impact downstream.
The added scenario ensures the
404check fails in2.0.4, and passes in the current version.Background 📜
2.0.4, files outside the root folder would 404.2.0.5, files outside the root folder are served as expected.