Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loadPreprocessor from both configFile path and cwd fix(#2612) #2702

Closed
wants to merge 1 commit into from
Closed

fix: loadPreprocessor from both configFile path and cwd fix(#2612) #2702

wants to merge 1 commit into from

Conversation

HomyeeKing
Copy link
Contributor

@HomyeeKing HomyeeKing commented Mar 26, 2021 •
edited
Loading

Description

close #2612

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HomyeeKing HomyeeKing changed the title fix: loadPreprocessor from both configFile path and cwd fix: loadPreprocessor from both configFile path and cwd fix(#2612) Mar 26, 2021
Shinigami92
Shinigami92 previously approved these changes Mar 26, 2021
View reviewed changes
@Shinigami92 Shinigami92 added p2-nice-to-have Not breaking anything but nice to have (priority) enhancement New feature or request 🔍 review needed labels Mar 26, 2021
@HomyeeKing
Copy link
Contributor Author

how about this PR, need I to resolve the conflicts?

@Shinigami92
Copy link
Member

Shinigami92 commented Apr 9, 2021 •
edited
Loading

how about this PR, need I to resolve the conflicts?

Yes, please resolve all conflicts

@ferdinando-ferreira ferdinando-ferreira mentioned this pull request Jul 2, 2021
Merged
9 tasks
@patak-dev
Copy link
Member

Thanks for the PR @HomyeeKing, closing as it looks like #3988 was merged fixing #2612

@patak-dev patak-dev closed this Jul 2, 2021
@HomyeeKing HomyeeKing deleted the fix/processor branch July 3, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@antfu antfu Awaiting requested review from antfu

@patak-dev patak-dev Awaiting requested review from patak-dev

Assignees
No one assigned
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS processors aren't considered installed if root is placed outside of vite.config's folder
3 participants
@HomyeeKing @Shinigami92 @patak-dev