fix(optimizer): ensure the js files in deps won't mark as external #2709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current behavior of prebundle (optimizer) will pack all deps in node_modules into chunks, whereas when it hit some js ending with assets ending, like
abc.scss.js
orxyz.svg.js
, vite will treat the js file as external so it won't be correctly bundled.For example, in office-ui-fabric-react:
The
stylesImport
will be resolved to'./Dropdown.scss.js'
with external marked, so it's generated likeWe expect that it should be something like
This PR fix this issue.
A similar issue described in #2492
Additional context
I'm not familiar with the testing infra here, and I'm still working with the test.... hopefully I can add a test for this soon.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).