Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: contributing.md extending test suite section #2946

Merged
merged 4 commits into from
Apr 14, 2021
Merged

docs: contributing.md extending test suite section #2946

merged 4 commits into from
Apr 14, 2021

Conversation

patak-dev
Copy link
Member

Description

Adds an example of a test in a new Extending the Test Suite in contributing.md

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title Chore/contributing tests chore: contributing.md extending test suite section Apr 11, 2021
Shinigami92
Shinigami92 approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone with better english-knowledge should also have a look 🙂

@patak-dev patak-dev requested a review from antfu April 12, 2021 21:11
@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Apr 12, 2021
@antfu antfu changed the title chore: contributing.md extending test suite section docs: contributing.md extending test suite section Apr 14, 2021
@antfu antfu merged commit 6dfba78 into vitejs:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patak-dev @Shinigami92 @antfu