Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error on directly use transformRequest api #3802

Closed
wants to merge 2 commits into from

Conversation

dejour
Copy link
Contributor

@dejour dejour commented Jun 14, 2021

Description

fix #3798

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 15, 2021
@Shinigami92 Shinigami92 requested a review from patak-dev June 15, 2021 09:49
@patak-dev
Copy link
Member

I don't think this is the correct change, or if there is a change needed. See my comment at the issue #3798 (comment).

In case we would like to support this, we could initialize the cache when the plugin is created, and reset it at build start. But IMO, plugins are meant to be used in the context of an initialized server.

@dejour
Copy link
Contributor Author

dejour commented Jun 15, 2021

I'm skeptical about using plugin this way too. so feel free to close this pull request.

@antfu antfu closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css-post plugins crashes when using transformRequest without first starting a server
4 participants