Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr/css): fix infinite recursion on hmr #3865

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

ferdinando-ferreira
Copy link
Contributor

Description

Fixes #3864. Description of the problem and reproduction steps are at that bug.

Additional context

Currently existing tests caught the error (on Windows only, for some reason), no additional tests needed.

The added check, && !currentChain.includes(importer), is the same as the check a couple of lines below (to prevent an importer already in the chain to be added back again).

if (currentChain.includes(importer)) {
// circular deps is considered dead end
return true
}


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) labels Jun 19, 2021
@patak-dev patak-dev requested a review from yyx990803 June 19, 2021 15:31
@yyx990803 yyx990803 merged commit 0d5726f into vitejs:main Jun 19, 2021
@ferdinando-ferreira ferdinando-ferreira deleted the fix-3864 branch June 19, 2021 19:52
javastation pushed a commit to javastation/vite that referenced this pull request Jun 22, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion on propagateUpdate
3 participants