fix(hmr/css): fix infinite recursion on hmr #3865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3864. Description of the problem and reproduction steps are at that bug.
Additional context
Currently existing tests caught the error (on Windows only, for some reason), no additional tests needed.
The added check,
&& !currentChain.includes(importer)
, is the same as the check a couple of lines below (to prevent an importer already in the chain to be added back again).vite/packages/vite/src/node/server/hmr.ts
Lines 257 to 260 in 6eaec3a
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).