fix(create-app): distinguish pnpm pkgManager #4193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Jul 9, 2021
packages/create-app/index.js
Outdated
| ? 'yarn' | ||
| : /npm/.test(process.env.npm_execpath) | ||
| ? 'npm' | ||
| : 'pnpm' |
There was a problem hiding this comment.
I think we should make the fallout to npm instead of pnpm, for detecting what pm is used, here is a reference
https://github.com/zkochan/packages/blob/master/which-pm-runs/index.js
Shinigami92
added
the
p3-minor-bug
|
Sorry, I can only barely understand what you mean because my English is not that good, but I think the modification I made may be what you mean, and thank you for your guidance. |
antfu
reviewed
Jul 10, 2021
antfu
previously approved these changes
Jul 10, 2021
Shinigami92
reviewed
Jul 10, 2021
Shinigami92
previously approved these changes
Jul 10, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I use
pnpm init @vitejs/appto create a vite app, finally it has two tip callednpm installnpm run dev, so I think create-app can't distinguish pnpm pkgManager, more and more people are using pnpm, so I think it's better to do this, and now it can distinguish pnpm.Additional context
none
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).