Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dependency resolution warning, closes #4089 #4197

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

tamasfe
Copy link
Contributor

@tamasfe tamasfe commented Jul 9, 2021

Description

Added a warning about the differences in vite's and rollup's dependency resolution that caused confusion in #4089.

Additional context

This was the only relevant page I found to put this warning on, I'm not sure if there is a better place for it.

I haven't built and ran the docs site, just edited the page, the note syntax was copied from an another page, I'm not sure if it works and looks correct.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Jul 9, 2021
@patak-dev patak-dev merged commit 4c7af0a into vitejs:main Aug 25, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants