fix(dev): only rewrite SSR stacktrace when possible

[GrygrFlzr]

Current Behavior

vite/packages/vite/src/node/server/index.ts

Lines 367 to 371 in 772b2f7

	ssrFixStacktrace(e) {
	if (e.stack) {
	e.stack = ssrRewriteStacktrace(e.stack, moduleGraph)
	}
	},

vite/packages/vite/src/node/ssr/ssrModuleLoader.ts

Lines 144 to 146 in 772b2f7

	e.stack = ssrRewriteStacktrace(e.stack, moduleGraph)
	server.config.logger.error(
	`Error when evaluating SSR module ${url}:\n${e.stack}`,

Currently, Vite assumes that the stack property of an error will always be writable. Unfortunately, this is not always the case, as seen here in the discord-oauth2 module:

Object.defineProperty(this, "stack", {
    value: this.message + "\n" + stack,
    writable: false,
});

This leads to errors inside ssrFixStacktrace:

TypeError: Cannot assign to read only property 'stack' of object 'DiscordHTTPError: 400 Bad Request on POST /api/v7/oauth2/token'

Proposed Behavior

1. Check if the property is configurable (i.e. redefinable with Object.defineProperty). If so, redefine the property.
2. Otherwise, check if the property is writable. If so, perform assignment to the property.
3. If all else fails, leave the stacktrace untouched.

As ssrFixStacktrace is an in-place operation, we cannot return a new error object with the redefined stack-trace. I am unsure if there's a better way to handle this.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[aleclarson]

Should we warn if neither configurable nor writable, so the dependency gets fixed?

[GrygrFlzr]

Hm, emitting the warning properly would require server instance, which wouldn't be accessible inside rebindErrorStacktrace. Would it be better to:

Pass in a server instance to have rebindErrorStacktrace emit the warning?

function rebindErrorStacktrace(e: Error, stacktrace: string, server: ViteDevServer): void

Return a boolean for success and have the respective consumers emit the warning? There probably would also be more context available for more detailed errors.

function rebindErrorStacktrace(e: Error, stacktrace: string): boolean

[aleclarson]

I'm thinking we should deprecate ssrRewriteStacktrace in favor of a SSRError extends Error subclass whose constructor takes a stack trace string. So for now, I vote to merge this PR as-is.