Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing user define in the code in node_modules may cause errors #4456

Closed
wants to merge 2 commits into from

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Jul 31, 2021

Description

fix #4271
The define plugin replaces the user define in the code of dependency in node_modules. As the user define is easy to overlap with the part code of the dependency, it may cause unexpected bugs after the replacement tasks effect.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@y1d7ng y1d7ng marked this pull request as draft August 1, 2021 04:05
@y1d7ng y1d7ng closed this Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define plugin is replacing code in node modules leading to failing builds
1 participant