Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: KiB instead of kb unit #4493

Merged
merged 1 commit into from
Aug 5, 2021
Merged

chore: KiB instead of kb unit #4493

merged 1 commit into from
Aug 5, 2021

Conversation

Mesteery
Copy link
Contributor

@Mesteery Mesteery commented Aug 3, 2021

Description

kb is wrong as a unit, because they are not kilobytes, but kibibytes.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Mesteery
feat(reporter): KiB instead of kb unit
afb552a 
`kb` is wrong as a unit, because they are not kilobytes, but kibibytes.
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 3, 2021
@antfu antfu changed the title feat(reporter): KiB instead of kb unit chore: KiB instead of kb unit Aug 5, 2021
@antfu antfu merged commit 66060ea into vitejs:main Aug 5, 2021
@Mesteery Mesteery deleted the patch-2 branch August 5, 2021 23:35
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@Mesteery @aleclarson
chore: KiB instead of kb unit (vitejs#4493)
55fccf3
@patak-dev patak-dev mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mesteery @Shinigami92 @antfu