Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exit build with error when fail to resolve module (fix #459) #466

Merged
merged 1 commit into from
Jul 2, 2020
Merged

feat: exit build with error when fail to resolve module (fix #459) #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/node/build/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ const dynamicImportWarningIgnoreList = [
export const onRollupWarning: (
spinner: Ora | undefined
) => InputOptions['onwarn'] = (spinner) => (warning, warn) => {
if (warning.code === 'UNRESOLVED_IMPORT') {
console.error(
chalk.red(`[vite]: Rollup failed to resolve a module, this is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to \`rollupInputOptions.external\``)
)
throw new Error(warning.message)
}
if (
warning.plugin === 'rollup-plugin-dynamic-import-variables' &&
dynamicImportWarningIgnoreList.some((msg) => warning.message.includes(msg))
Expand Down