-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): return sourcemap in vite:css transform #4880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this wasn't caught before by someone
This PR seems to have an impact on the |
@hex-ci did you open an issue in vite-plugin-vue2? Maybe this is something to be solved there? Please link the issue for reference here |
I created an issue: underfin/vite-plugin-vue2#132 |
@patak-js The problem mentioned in #4939 seems to affect not only Vue 2, but also Vue 3. |
Oh, I think you should also open an issue here to track it |
This reverts commit 015290a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
return actual sourcemap for css transform instead of a dummy
Additional context
may fix #649
Note i didn't do any further analysis besides running the tests, but this seems like a trivial change for the better, can't get more broken than that dummy.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).