fix(vite): fix 4964(Windows drive letter inconsistency) #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CGQAQ <m.jason.liu@outlook.com>
Signed-off-by: CGQAQ <m.jason.liu@outlook.com>
CGQAQ
changed the title
Signed-off-by: CGQAQ <m.jason.liu@outlook.com>
|
Ready for review |
CGQAQ
changed the title
Shinigami92
previously approved these changes
Sep 19, 2021
patak-dev
requested changes
Sep 19, 2021
Co-authored-by: patak <matias.capeletto@gmail.com>
patak-dev
approved these changes
Sep 19, 2021
Shinigami92
approved these changes
Sep 20, 2021
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Sep 22, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 16, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps generated by esbuild (and therefore completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. It doesn't change anything when using SvelteKit (where the problem did not exist in the first place). When using SolidStart, the problem still persists, likely because it doesn't use the `transformWithEsbuild` function, and therefore needs a follow up fix. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 cc @jecfish [^1]: https://goo.gle/devtools-vite-interoperability
4 tasks
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 16, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps generated by esbuild (and therefore completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. It doesn't change anything when using SvelteKit (where the problem did not exist in the first place). When using SolidStart, the problem still persists, likely because it doesn't use the `transformWithEsbuild` function, and therefore needs a follow up fix. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 16, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps generated by esbuild (and therefore completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. It doesn't change anything when using SvelteKit (where the problem did not exist in the first place). When using SolidStart, the problem still persists, likely because it doesn't use the `transformWithEsbuild` function, and therefore needs a follow up fix. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 16, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps generated by esbuild (and therefore completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. It doesn't change anything when using SvelteKit (where the problem did not exist in the first place). When using SolidStart, the problem still persists, likely because it doesn't use the `transformWithEsbuild` function, and therefore needs a follow up fix. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 23, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps for transformer outputs (and thereby completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 23, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps for transformer outputs (and thereby completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 24, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps for transformer outputs (and thereby completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
bmeurer
added a commit
to bmeurer/vite
that referenced
this pull request
Feb 24, 2023
This refines the fix from vitejs#4985 to turn absolute paths into relative paths for the `sources` array in source maps for transformer outputs (and thereby completely avoids the Windows drive letter problem). In order to minimize unintended negative side effects, we perform this step only when the source file name is absolute. This addresses the issue that source files show up with an absolute path prefix in case of Vue[^1]. Bug: https://crbug.com/1411596 Ref: vitejs#4964 Ref: vitejs#4912 [^1]: https://goo.gle/devtools-vite-interoperability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CGQAQ m.jason.liu@outlook.com
Description
fixed #4964
fixed #4912
This is what main branch code will be like, mixup uppercase and lowercase drive letters
Now it will works perfectly!
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).