Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: server.address before listen, chdir in test, basic cli test #5059

Merged
merged 17 commits into from
Sep 27, 2021
Merged

fix: server.address before listen, chdir in test, basic cli test #5059

merged 17 commits into from
Sep 27, 2021

Commits on Sep 26, 2021

  1. test(cli): add playground with tests for cli

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    72c18a0 View commit details
    Browse the repository at this point in the history

  2. fix: improve check condition if cli process kill was successful

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    5cf68de View commit details
    Browse the repository at this point in the history

  3. fix: use detached process for cli server and kill it with native comm… 

    …ands; add promise race helper
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    d59d700 View commit details
    Browse the repository at this point in the history

  4. fix: remove unused timeout param and increase start timeout to 5s

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9981286 View commit details
    Browse the repository at this point in the history

  5. wip: see if ipc works

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    4b43e29 View commit details
    Browse the repository at this point in the history

  6. wip: remove detached: true. only send additional taskkill command on … 

    …windows
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fc29624 View commit details
    Browse the repository at this point in the history

  7. wip: add --strict-port

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9f2f178 View commit details
    Browse the repository at this point in the history

  8. refactor: remove nested finally and add back error log for failed ser… 

    …ver start
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    11c2183 View commit details
    Browse the repository at this point in the history

  9. wip: log commands used on error

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    e58be2a View commit details
    Browse the repository at this point in the history

  10. wip: revert to state that ran successfully on linux/mac, add extra ta… 

    …skkill for windows only
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    fecf5da View commit details
    Browse the repository at this point in the history

  11. wip: don't rely on execa preferLocal, call vite bin with relative path

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    0a3c3a3 View commit details
    Browse the repository at this point in the history

  12. fix: use viteBin for server process too

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    0c5218d View commit details
    Browse the repository at this point in the history

  13. fix: refactor postcss-caching test to not call process.chdir and sile… 

    …nce server logs
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    9a02e48 View commit details
    Browse the repository at this point in the history

  14. fix: enforce localhost for cli test and avoid logger error when tryin… 

    …g to log network details
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    6b54ce7 View commit details
    Browse the repository at this point in the history

  15. fix: call server.listen() before accessing server.address() to get th… 

    …e actual address; restore original for startup duration
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    29dd8d1 View commit details
    Browse the repository at this point in the history

  16. wip: and another round of windows improvement

    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    bdd36bd View commit details
    Browse the repository at this point in the history

  17. refactor: cleanup serve implementation in cli playground, improve err… 

    …or messages
    @dominikg
    dominikg committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    76b59b9 View commit details
    Browse the repository at this point in the history