workflow: switch to pnpm #5060

yyx990803 · 2021-09-23T20:35:43Z

No description provided.

dominikg · 2021-09-23T22:39:36Z

scripts/release.js has a few uses of yarn.
here's how it was converted to pnpm in vite-plugin-svelte https://github.com/sveltejs/vite-plugin-svelte/blob/main/scripts/release.js

dominikg · 2021-09-23T22:45:43Z

and on ci setup node action can also take care of pnpm cache now, https://github.com/sveltejs/vite-plugin-svelte/blob/36a087bd6b2cb303f13c6c91a3fae1decf26c5cc/.github/workflows/ci.yml#L31

yyx990803 · 2021-09-23T23:28:23Z

Ugh, looks like we have the tests passing on every platform but Windows... that's going to be very hard to debug...

zkochan · 2021-09-24T00:10:11Z

Let me know if you need some help or if there are some issues with pnpm that I need to prioritize.

zkochan · 2021-09-24T00:17:26Z

.github/workflows/ci.yml


      - name: Build vite
-        run: yarn ci-build-vite
+        run: pnpm run ci-build-vite


you may actually keep the Yarn syntax here if you wish. run is optional with pnpm as well.

Though you still have to escape options with -- like you did. We will probably make that work without -- in the future (pnpm/pnpm#3778)

Yeah, I'm just doing it for consistency's sake

zkochan · 2021-09-24T00:30:20Z

scripts/patchFileDeps.js

+// pnpm treats file: protocols as link:, so it doesn't copy the actual files
+// into node_modules, causing Vite to still consider those deps linked.
+// This script is called from postinstall hooks in playground packages that
+// uses the file: protocol, and copies the file: deps into node_modules.


I think this issue is about a similar use case: pnpm/pnpm#3510

It does sound similar. I also tried using .npmrc inside a sub-package with package-import-method but it didn't seem to work.

yyx990803 · 2021-09-24T02:01:58Z

I believe this is now ready. But let's hold off until tomorrow's team meeting.

Tests are passing
Contribution guide updated
Relevant part in docs updated
Docs Netlify deploy config updated (also forces using locally built vite & plugin-vue via pnpm.override in package.json, build passing on Netlify)

Some notes on tests:

Due to pnpm's strictness, all playground repos must explicitly specify used deps (unless the dep is available in workspace root package.json)
Tests that rely on Yarn's file: protocol behavior must add a postinstall script that runs script/patchFileDeps to replicate Yarn's behavior.

Shinigami92

If you don't want to rush this, please give me the chance to test this on my local machine(s).
currently I'm on mobile, will have time in about next 12h

packages/playground/extensions/package.json

.github/workflows/ci.yml

packages/playground/nested-deps/vite.config.js

Shinigami92 · 2021-09-24T06:32:38Z

Following was made on Arch Linux x86_64 5.10.68-1-lts

Process for a newcomer/switcher to pnpm

Checkout fork git clone git@github.<Username>/vite.git
Install tools like yay or install nativly
yarn is directly available via pacman (https://archlinux.org/packages/community/any/yarn/)
pnpm needs to be installed via AUR (https://aur.archlinux.org/packages/pnpm-bin/)
pnpm is not like yarn, you need to append install
After executing pnpm install the pnpm-lock.yaml changed 👀
I think we need to exclude pnpm-lock.yaml from prettier ⚠️ (.prettierignore line 9: yarn.lock -> pnpm-lock.yaml)

yarn build: 52s
pnpm build: 55s

yarn test-serve --runInBand: 1min 13s
pnpm test-serve -- --runInBand: 1min 18s

yarn test-build --runInBand: 1min 9s
pnpm test-build -- --runInBand: 1min 14s

antfu · 2021-09-24T07:00:58Z

Re: @Shinigami92

2: why not npm i -g pnpm or npx pnpm add -g pnpm? Many options here: https://pnpm.io/installation
3: actually that is more aligned to npm. Using either yarn or pnpm is already asking contributors to learn another tool, I didn't see much difference here.

Perf: benching build/test does not make much sense since most works are on the node side. Wondering what's the difference on deps installations?

Side note: yarn v3 failed to distinguish the binaries as well:

packages/playground/testUtils.ts

.github/workflows/ci.yml

CONTRIBUTING.md

Co-authored-by: Shinigami <chrissi92@hotmail.de>

yyx990803 force-pushed the pnpm branch from 18ae15d to 640800e Compare September 23, 2021 20:35

yyx990803 added 8 commits September 23, 2021 16:38

wip: some tests are not passing

39c7ac8

build: link vite to root

36dc8da

wip: some progress

bcd89da

wip: some test progress

c06da90

wip: fix more tests

3af0c1e

wip: more progress

8d67732

wip: all tests pass!

aff8b20

ci: use pnpm on ci

f9fc4c1

yyx990803 force-pushed the pnpm branch from 640800e to f9fc4c1 Compare September 23, 2021 20:39

yyx990803 added 3 commits September 23, 2021 16:41

chore: lockfile

02ad3f5

ci: update config

149b816

ci: make pnpm happy

a79ca27

yyx990803 force-pushed the pnpm branch from e02016a to a79ca27 Compare September 23, 2021 21:04

wip: save

9021caf

yyx990803 added 6 commits September 23, 2021 18:56

ci: workaround pnpm file protocol issues

3887379

ci: install pnpm first

d86ec6e

ci: fix pnpm run flags

96994d5

ci: fix lint

8cc134b

ci: fix nested workspace package

110ffa7

ci: simplify workspace config

3f64161

yyx990803 added 3 commits September 23, 2021 19:33

chore: update yarn references

e359558

docs: add note about pnpm file protocol

2ccaff6

ci: attemp to fix test case on windows

2b51670

zkochan reviewed Sep 24, 2021

View reviewed changes

ci: use consistent steps for lint

e90886d

yyx990803 added 4 commits September 23, 2021 21:39

docs: force docs to use locally built vite + use pnpm for netlify

7017dae

docs: fix netlify npm flags

b7dc93f

fix: remove yarn usage in vite build script

f7ff379

workflow: update release script [ci skip]

6af8527

Shinigami92 suggested changes Sep 24, 2021

View reviewed changes

packages/playground/extensions/package.json Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

packages/playground/nested-deps/vite.config.js Outdated Show resolved Hide resolved

dominikg reviewed Sep 24, 2021

View reviewed changes

packages/playground/testUtils.ts Show resolved Hide resolved

dominikg mentioned this pull request Sep 24, 2021

fix: server.address before listen, chdir in test, basic cli test #5059

Merged

9 tasks

dominikg reviewed Sep 24, 2021

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

yyx990803 added 5 commits September 24, 2021 10:38

chore: revert unintended test case change

41356c5

chore: ignore pnpm files from prettier

3eadde3

chore: update jest ignore pattern

a5cb940

ci: fix lint workflow

fd16627

Merge branch 'main' into pnpm

2a8b559

Shinigami92 reviewed Sep 24, 2021

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

Update CONTRIBUTING.md

7d86fde

Co-authored-by: Shinigami <chrissi92@hotmail.de>

yyx990803 merged commit 3e1cce0 into main Sep 24, 2021

jplhomer mentioned this pull request Nov 5, 2021

Hydrogen behaves differently between dev monorepo and a standalone app Shopify/hydrogen-v1#43

Closed

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021

workflow: switch to pnpm (vitejs#5060)

2e1992b

sondr3 mentioned this pull request Nov 9, 2021

[chore] use actions/setup-node@v2 for caching, add pnpm/action-setup sveltejs/kit#2765

Merged

5 tasks

antfu deleted the pnpm branch December 24, 2021 05:04

Rhilip mentioned this pull request Mar 15, 2022

json messages is empty when use pnpm intlify/vue-cli-plugin-i18n#204

Open

mrienstra mentioned this pull request Sep 12, 2022

Migration to ES Modules facebook/docusaurus#6520

Open

1 task

mrienstra mentioned this pull request Oct 6, 2022

Migrate to pnpm or Yarn 3 (from Yarn 1) microsoft/vscode#162803

Closed

vscodenpa mentioned this pull request Oct 6, 2022

Migrate to pnpm or Yarn 3 (from Yarn 1) vscodenpa/testissues#9487

Open

mrienstra mentioned this pull request Oct 7, 2022

Migrating to pnpm from Yarn (links) pnpm/pnpm.io#337

Open

mrienstra mentioned this pull request Nov 15, 2023

Move to pnpm or Yarn >=3 netlify/netlify-ipx#226

Open

nozomuikuta mentioned this pull request Dec 12, 2023

chore: switch from yarn to pnpm vitejs/docs-ja#1256

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

workflow: switch to pnpm #5060

workflow: switch to pnpm #5060

yyx990803 commented Sep 23, 2021

dominikg commented Sep 23, 2021

dominikg commented Sep 23, 2021

yyx990803 commented Sep 23, 2021

zkochan commented Sep 24, 2021 •

edited

Loading

zkochan Sep 24, 2021

yyx990803 Sep 24, 2021

zkochan Sep 24, 2021

yyx990803 Sep 24, 2021

yyx990803 commented Sep 24, 2021 •

edited

Loading

Shinigami92 left a comment

Shinigami92 commented Sep 24, 2021 •

edited

Loading

antfu commented Sep 24, 2021 •

edited

Loading

workflow: switch to pnpm #5060

workflow: switch to pnpm #5060

Conversation

yyx990803 commented Sep 23, 2021

dominikg commented Sep 23, 2021

dominikg commented Sep 23, 2021

yyx990803 commented Sep 23, 2021

zkochan commented Sep 24, 2021 • edited Loading

zkochan Sep 24, 2021

Choose a reason for hiding this comment

yyx990803 Sep 24, 2021

Choose a reason for hiding this comment

zkochan Sep 24, 2021

Choose a reason for hiding this comment

yyx990803 Sep 24, 2021

Choose a reason for hiding this comment

yyx990803 commented Sep 24, 2021 • edited Loading

Shinigami92 left a comment

Choose a reason for hiding this comment

Shinigami92 commented Sep 24, 2021 • edited Loading

antfu commented Sep 24, 2021 • edited Loading

zkochan commented Sep 24, 2021 •

edited

Loading

yyx990803 commented Sep 24, 2021 •

edited

Loading

Shinigami92 commented Sep 24, 2021 •

edited

Loading

antfu commented Sep 24, 2021 •

edited

Loading