fix: use the same target
for optimized dependencies and source files
#5095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4897
Description
It's the same as in
vite/packages/vite/src/node/plugins/esbuild.ts
Line 230 in 5d2c50a
As the default target is
modules
, optimizing dependencies no longer introduces the unicode export syntax, therefore the bug can be circumvented.Additional context
I would love to add tests but I haven't figured out how to set up a minimal reproduction in vite 😂
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).