fix(plugin-legacy): use terser as the default minifier #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
approved these changes
Oct 1, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
agriffis
added a commit
to agriffis/vite
that referenced
this pull request
Dec 27, 2021
This fixes two misbehaviors of the legacy plugin:
1. Respect {minify: false} for legacy assets.
2. Don't inflict es2019/terser on non-legacy chunks.
For the first problem, we could have fixed by checking for false in
viteLegacyPlugin.config(). Unfortunately that would have left the second
problem unsolved. Without adding significant complexity to the config,
there's no easy way to use different minifiers in the build depending on
the individual chunk.
So instead we include terserPlugin() whenever minify is enabled, even
true or 'esbuild', then check the actual configuration in the plugin.
This allows the legacy plugin to inject its special override, leaving
all the non-legacy stuff intact and uncomplicated.
See also, previous attempts: vitejs#5157 vitejs#5168
9 tasks
agriffis
added a commit
to agriffis/vite
that referenced
this pull request
Dec 27, 2021
This fixes two misbehaviors of the legacy plugin:
1. Respect {minify: false} for legacy assets.
2. Don't inflict es2019/terser on non-legacy chunks.
For the first problem, we could have fixed by checking for false in
viteLegacyPlugin.config(). Unfortunately that would have left the second
problem unsolved. Without adding significant complexity to the config,
there's no easy way to use different minifiers in the build depending on
the individual chunk.
So instead we include terserPlugin() whenever minify is enabled, even
true or 'esbuild', then check the actual configuration in the plugin.
This allows the legacy plugin to inject its special override, leaving
all the non-legacy stuff intact and uncomplicated.
See also, previous attempts: vitejs#5157 vitejs#5168
agriffis
added a commit
to agriffis/vite
that referenced
this pull request
Dec 27, 2021
This fixes two misbehaviors of the legacy plugin:
1. Respect {minify: false} for legacy assets.
2. Don't inflict es2019/terser on non-legacy chunks.
For the first problem, we could have fixed by checking for false in
viteLegacyPlugin.config(). Unfortunately that would have left the second
problem unsolved. Without adding significant complexity to the config,
there's no easy way to use different minifiers in the build depending on
the individual chunk.
So instead we include terserPlugin() whenever minify is enabled, even
true or 'esbuild', then check the actual configuration in the plugin.
This allows the legacy plugin to inject its special override, leaving
all the non-legacy stuff intact and uncomplicated.
See also, previous attempts: vitejs#5157 vitejs#5168
agriffis
added a commit
to agriffis/vite
that referenced
this pull request
Dec 27, 2021
This fixes two misbehaviors of the legacy plugin:
1. Respect {minify: false} for legacy assets.
2. Don't inflict es2019/terser on non-legacy chunks.
For the first problem, we could have fixed by checking for false in
viteLegacyPlugin.config(). Unfortunately that would have left the second
problem unsolved. Without adding significant complexity to the config,
there's no easy way to use different minifiers in the build depending on
the individual chunk.
So instead we include terserPlugin() whenever minify is enabled, even
true or 'esbuild', then check the actual configuration in the plugin.
This allows the legacy plugin to inject its special override, leaving
all the non-legacy stuff intact and uncomplicated.
See also, previous attempts: vitejs#5157 vitejs#5168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5157
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).