feat: add ssrRequire in ssrloadmodule for #5424

[zhangyuang]

Description

for #5424

require keywords is undefined when call ssrLoadmodule in entry-server file

Additional context

ssrModuleLoader function only inject NodeJs.Global in context but not NodeRequire which cause require is not defined error occur when evaluating !entry module. I can't determine whether vite do this on purpose. i think vite should support commonjs module syntax in nodejs environment because many old file code used it .

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• [ x] Read the Contributing Guidelines.
• [x ] Read the Pull Request Guidelines and follow the Commit Convention.
• [ x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• [ x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• [ x] Ideally, include relevant tests that fail without this PR but pass with it.

[zhangyuang]

cc @patak-js @antfu

[zhangyuang]

In the latest code, i add a function ssrRequire which load bare module by nodeRequire function and load module in entry file use nodejs native require function.
please cc @Shinigami92

[zhangyuang]

Maybe someone can follow up the pr? i am trying to add vite to transform server side code in my ssr framework replace webpack.i hope i can get more support @Shinigami92 @patak-js @antfu

[Shinigami92]

@zhangyuang I'm not the right person for SSR 🙁 sorry, hope someone else can help you
I will try merge the newest main into this branch, so the new CI will trigger correctly and the old node v14 checks will go away.

[zhangyuang]

thank you for response， i have succeed add vite in my ssr framework with npm link the change, i hope the changed code can be published in the official version

[Shinigami92]

Is it possible to add a test to the playground?

[zhangyuang]

ok, I was thinking exactly the same thing

[zhangyuang]

I have supplemented some test code in ssr-vue example, please review when free time @Shinigami92

[antfu]

LGTM. I will bring this to our team meeting and see if this is what we expect for Vite generally.

[zhangyuang]

Is there any progress 😊 @antfu

[Shinigami92]

@zhangyuang last fridays meeting we were only 3 members (mostly conflict with new sommer-winter time change). So in worst case could be that you need to wait another 1.5 week from now for next meeting, sry

[zhangyuang]

@zhangyuang last fridays meeting we were only 3 members (mostly conflict with new sommer-winter time change). So in worst case could be that you need to wait another 1.5 week from now for next meeting, sry

ok, take it easy,i am not hurried

[zhangyuang]

Active it, is there any progress? @Shinigami92 @antfu

[Shinigami92]

It's on p3 meeting notes 👍 Sadly Evan was not available last two meetings. Also seems that @antfu is very busy last days.
So sorry for that, but happens some times 🤷 Just be patient.

[zhangyuang]

Is there any progress? The feature is important for me 😭

[yyx990803]

Why is this important? What makes it absolutely necessary to use require() instead of import?

[zhangyuang]

Why is this important? What makes it absolutely necessary to use require() instead of import?

For example, i have some old code like

const getConfig = () => require(resolve(process.cwd() ,'./config'))

that need to used in server-entry

[zhangyuang]

Ref #5424

I will try use createRequire to use require syntax

[Shinigami92]

[...] i have some old code [...]

Maybe this is a problem and you should try to rewrite it to use new code 🤔

[zhangyuang]

yeah，now i transmit config by function params🤔 looks like can fix the problem, although a little uncomfortable 发自我的iPhone

…

------------------ Original ------------------ From: Shinigami ***@***.***> Date: Sat,Dec 4,2021 1:05 AM To: vitejs/vite ***@***.***> Cc: yuuang ***@***.***>, Mention ***@***.***> Subject: Re: [vitejs/vite] feat: add ssrRequire in ssrloadmodule for #5424 (PR#5425) [...] i have some old code [...] Maybe this is a problem and you should try to rewrite it to use new code 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[patak-dev]

Closing as #5424 has been closed. We are also planning to move to ESM by default in SSR, see #8150