Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(esbuild): respect esbuild config on build #5538

Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix(esbuild): respect esbuild config on build #5538

merged 1 commit into from
Nov 3, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Nov 3, 2021

Description

I guess this is something missed from refactoring. Currently, this blocks Nuxt Bridge on the build.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Nov 3, 2021
@antfu antfu mentioned this pull request Nov 3, 2021
Merged
7 tasks
@patak-dev patak-dev merged commit ff05fe9 into vitejs:main Nov 3, 2021
@antfu antfu deleted the fix/esbuild-build branch November 3, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

Assignees
No one assigned
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @patak-dev